Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

v5 ContractFactory.deploy() ignores transaction overrides

See original GitHub issue

In ethers-v5 a deployment transaction such as factory.deploy({ gasPrice, gasLimit }) ignores the transaction overrides. I think the problem is in resolveAddresses() called from here: https://github.com/ethers-io/ethers.js/blob/db604aa6afc007f8198fc730b7db4f9ae3876c58/packages/contracts/src.ts/index.ts#L982-L983 https://github.com/ethers-io/ethers.js/blob/db604aa6afc007f8198fc730b7db4f9ae3876c58/packages/contracts/src.ts/index.ts#L84-L91 which maps on paramType = this.interface.deploy.inputs = [] and so returns nothing.

Issue Analytics

State:
Created 3 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

pyggiecommented, Apr 27, 2020

It works!

1reaction

ricmoocommented, Apr 24, 2020

I’ve reproduced it and am re-factoring a bit of that code now which should address this issue and clean things up a bit.

Top Results From Across the Web

ContractFactory - Ethers.js

Returns the unsigned transaction which would deploy this Contract with args passed to the Contract's constructor. If the optional overrides is specified, they ......

solidity - Contract Factory Deploy Function Variables

If the optional overrides is specified, they can be used to override the endowment value, transaction nonce, gasLimit or gasPrice.

@ethersproject/properties | Yarn - Package Manager

Tweaked test case to re-order transaction after event listeners added. · Ignore errors when resolving ENS resolver properties. · Enable CCIP Read for...

How to Build a Full Stack NFT Marketplace - V2 (2022)

Redeploy with this script, by replacing main() in deploy.js with: ... console.log(`NFT hash: ${txHash}\nWaiting for transaction to be mined.

Release Notes — Web3.py 5.31.3 documentation

Deprecated buildTransaction and estimateGas in contract.py v5, ... AsyncHTTPProvider doc Supported Methods to include web3.eth.send_raw_transaction() .