question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add a `credentials` section to the `fidesctl.toml` config file that allows users to store credentials

See original GitHub issue

Is your feature request related to a specific problem?

We need a way for users to be able to store credentials in their fidesctl.toml files or as env vars.

Describe the solution you’d like

We should use a key/value solution so that we can be flexible with our connection types, and also allow users to call that connection information via an id

Describe alternatives you’ve considered, if any

A description of any alternative solutions or features you’ve considered.

Additional context

Potential toml design:

[credentials.postgres]
postgres_conn_1 = "postgresql+psycopg2://postgres:fidesctl@fidesctl-db:5432/fidesctl_test"

[credentials.aws]
aws_creds_1 = {access_key_id=<something>, secret_access_key=<some_key>, default_region=<some_region>}

then the env vars would look like:

FIDESCTL__CREDENTIALS__POSTGRES_POSTGRES_CONN_1="<some creds>"
FIDESCTL__CREDENTIALS__AWS_AWS_CREDS_1_ACCESS_KEY_ID="<some id>"
FIDESCTL__CREDENTIALS__AWS_AWS_CREDS_1_SECRET_ACCESS_KEY="<some access key>"
FIDESCTL__CREDENTIALS__AWS_AWS_CREDS_1_DEFAULT_REGION="<some default region>"

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
sanders41commented, May 6, 2022

Yes I agree. I was only thinking suggesting they gitignore it if sensitive info has been added.

1reaction
ThomasLaPianacommented, May 6, 2022

@SteveDMurphy while the toml can’t directly load values from env vars, it’s just one of the sources we populate our internal config from.

We prioritize env vars over the toml, but in the end they both get loaded into our internal python config. We give users the option of injecting either via env vars or putting them in the toml config.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Saving security credentials in a config file
To enable the security settings, enter the include-credentials command. ... memory and do not allow you to include and view them in the...
Read more >
Configuration and credential file settings - AWS Documentation
The AWS CLI stores sensitive credential information that you specify with aws configure in a local file named credentials , in a folder ......
Read more >
Credentials Options in Configuration Data - PowerShell
The Azure Automation DSC service allows you to centrally manage credentials to be compiled in configurations and stored securely.
Read more >
Configuration - Fides
The Fides application configuration variables are provided in a fides.toml file. Fides will use the first config file it reads from the following...
Read more >
git-credential-store Documentation - Git
This command stores credentials indefinitely on disk for use by future Git programs. You probably don't want to invoke this command directly; it...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found