Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fides ctl postgres dataset annotation coverage tests are failing

See original GitHub issue

Bug Description

Quite suddenly and without a clear cause, the annotation tests for postgres have started failing.

Additional context

On a change that is completely unrelated, it seemed to start failing: link to failed job

This is the earliest one I could find, but there might be earlier ones

Issue Analytics

State:
Created a year ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

NevilleScommented, Nov 3, 2022

I think this might have a simpler answer based on my initial sniff test… when inspecting this, the failures are:

tests/ctl/core/test_dataset.py::TestDatabase::test_get_db_tables[postgresql]
tests/ctl/core/test_dataset.py::TestDatabase::test_generate_dataset_passes_[postgresql]
tests/ctl/core/test_dataset.py::TestDatabase::test_dataset_coverage_manifest_passes[postgresql]

I call that out because @ThomasLaPiana and I definitely were making some updates to the default test PostgreSQL schema in other PRs, like this: https://github.com/ethyca/fides/pull/1609/files#diff-b649d6f7bfd020601ed8c65679441f25e5fe3c986d95fda02b4ec15e4cd10169

I think one possible explanation is that these “external” tests don’t run in CI unless you apply the run-unsafe-checks label and we weren’t doing that.

0reactions

ThomasLaPianacommented, Nov 4, 2022

Thank you all!

Ok, I’ll think more on this solution and ship a fix within the sprint 🙂