Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove the action field and add an "extra" inclusion enum

See original GitHub issue

Splitting up issues from #88

Right now it looks like we don’t look at the action field in a policy rule. By default any rule created will be treated as a reject. Here is the enums we allow right now:

ACCEPT
REJECT
REQUIRE

We need to come up with a strategy for handling these

Issue Analytics

State:
Created 2 years ago
Comments:17 (17 by maintainers)

Top GitHub Comments

1reaction

PSalant726commented, Dec 20, 2021

@iamkelllly The action field is being removed altogether, since only REJECT was ever used, and so the assumption going forward will be that all policy rules REJECT.

1reaction

NevilleScommented, Dec 8, 2021

After discussing I realize that ONLY works if you assume it’s an accept rule (e.g. ACCEPT this system if it ONLY uses these categories), but since the rule is still going to be a REJECT we kinda need to figure out the opposite of ONLY.

Here’s a decent verb for this that works with the rest, I think: OTHER

Putting into practice…

REJECT this system if ANY of these categories are used: user.provided.identifiable.contact.email, user.provided.identifiable.contact.phone_number
REJECT this system if ALL of these categories are used together: user.provided.identifiable.contact.email, user.provided.identifiable.contact.phone_number
REJECT this system if OTHER categories are used that are not: user.provided.identifiable.contact.email, user.provided.identifiable.contact.phone_number