Unzip stops prematurely in Node 0.10.0

Unzip stops prematurely in Node 0.10.0 without an error when inflating compressed files that are larger than the zlib stream’s highWaterMark (16 kb). I believe the issue is the line self._untilStream.pipe(vars.compressedSize, inflater).pipe(entry) - the inflater stream never emits ‘end’ or ‘finish’.

Code:

if (fileSizeKnown) {
  entry.size = vars.uncompressedSize;
  self._untilStream.pipe(vars.compressedSize, inflater).pipe(entry);
}

The error surfaced while I was investigating #19.

[tomitrescak]

Hi, I installed from npm, used as:

fs
            .createReadStream(req.file.path)
            .pipe(
              unzip.Extract({
                path: webBuildFolder
              }).on('close', function() {
                console.log('NOW!');
              })
            )

And getting error with Mac packed archives:

invalid signature: 0xa

[ashelley]

Hello I was having an issue with close not being called when these errors were happening for parser.on(‘error’):

entry:

Error: invalid signature: 0xa
    at /var/www/test/unzip-test/node_modules/unzip/lib/parse.js:59:13
    at processImmediate [as _immediateCallback] (timers.js:345:15)

entry:

Error: invalid code lengths set
    at Zlib._binding.onerror (zlib.js:295:17)

I ended up googling around and found this issue:

https://github.com/EvanOxfeld/node-unzip/issues/47

So i tried cloning this repo:

https://github.com/AnkurMali/node-unzip

And this fixed my problem,. The errors completely went away and I was able to extract the file (no error) and the close method was being called.