Zipfile signature not read

Referencing this issue https://github.com/joyent/node/issues/6384 here as it started out with me trying to use unzip with a github repo release zipfile

Summary: any release zipfile from a github repositiory will not work correctly by just piping the stream to unzip, e.g. as per example. fs.createReadStream('path/to/archive.zip').pipe(unzip.Extract({ path: 'output/path' })); As tjfontaine demonstrated in the response to issue the signature has to be read from the stream first before piping stuff to unzip.

More background on the signature: https://users.cs.jmu.edu/buchhofp/forensics/formats/pkzip.html

[seppevs]

I had the same issue. Switching to node-unzip-2 fixed it for me.

[bitmage]

It sounds like the “block lengths” and “block types” errors might be separate issues.

I’m working with a 3.5 MB zip file. When I use the Mac OSX compression tool to create the zip (right click on a folder and click Compress), then run it through node-unzip, I get “invalid stored block lengths”. When I compress the same directory using the zip command line utility, then node-unzip extracts it just fine.

Maybe the storage format has some variations that we’re not accounting for. I did a hex diff of the two files. I don’t know if it’s helpful to a keener eye than mine:

hex-diff.png