Architectural design suggestion

Hey @eveningkid, I want to contribute to this project, and when I read the code I noticed that you specify manually the DB types this library support https://github.com/eveningkid/denodb/blob/10d6447ac23a6b936ffbcfa5e0bc8a39e1c1f899/lib/database.ts#L56-L60

Then I though that it should have plugin architecture in a way that you should write something like:

// PostgresConnector and PostgresTranslator are a constructor
// PostgresPlugin will have {connector: PostgresConnector, translator: PostgresTranslator}
Database.register(PostgresPlugin)

Advantages

• Extract the implementation
• Reduce bundle size:
  • Only import DB connector that in use
• In case of a change in one connector no need to redeploy
• Solve the issue when some DB API change between DB versions

[eveningkid]

I think we’re good. If there is anything you want to talk about, feel free to use this issue or the PR you’ll create 😃

This might be quite a huge PR btw so try to keep it as simple as possible. I am sure you will do great!

You really have space to do what you feel is right so give it a try!

[rluvaton]

I think these details are about the implementation, not what the user will think about. What I mean is that, if this comes with a translator and others, this is not something the user cares about.

Yeah, I was talking about the implementation cause I was thinking about how to implement it.

This is what could happen under-the-hood:

class PostgreSQLConnector extends Connector {
  constructor(config) {
    this.translator = new PostgreSQLTranslator(); // or SQLTranslator() I forgot
    this.config = config;
  }
}

That looks fine 👍 , do you want me to start to implement it or there are things we forget to talk about?

If I think about what’s the simplest way of writing this (from our experience using ORMs), you just want to create a database and pass a configuration to it. No need to register anything else, even if we as developers see this as a plugin, right?

👍