Edge case with field name case conversion

If I have a field named flightID for example, it’s returned from DB as flightId:

import { DataTypes, Database, Model } from "https://deno.land/x/denodb/mod.ts";

const db = new Database("sqlite3", {
  filepath: "temp.db",
});

class Flight extends Model {
  static table = "flights";
  static timestamps = true;

  static fields = {
    flightID: {
      primaryKey: true,
      autoIncrement: true,
    },
    departure: DataTypes.STRING,
  };
}

db.link([Flight]);

await db.sync({ drop: true });

await Flight.create([
  {
    departure: "Paris",
  },
  {
    departure: "London",
  },
]);

console.log(await Flight.all());

Output

[
  {
      flightId: 1,
      departure: "Paris",
      createdAt: "2020-06-06 15:03:54",
      updatedAt: "2020-06-06 15:03:54"
    },
  {
      flightId: 2,
      departure: "London",
      createdAt: "2020-06-06 15:03:54",
      updatedAt: "2020-06-06 15:03:54"
    }
]

[Coteh]

Hey man that’s no problem, so sorry I didn’t get back! I wanted to get around to this at some point but was wrapped up in other projects. What you proposed was a good solution!

On Jun 15, 2020, at 8:02 AM, Arnaud Dellinger <[e-mail]:[e-mail]> wrote:

James, in case you ever see this, I will take over as it’s been raised by another issue. I bet you’re just busy so no worries 😃

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/eveningkid/denodb/issues/43#issuecomment-644086715, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAY74PRY5WEYRICVFOVFKFTRWYEUTANCNFSM4NWCMB4Q.

[Coteh]

Actually, wouldn’t mind taking a stab at it! 😃

We can have the field name be automatically converted by default (as it currently does) but the fieldNames property can be provided to Model if you want to override any of them, like what you showed above. What do you think?

On Jun 6, 2020, at 1:02 PM, Arnaud Dellinger <[e-mail]:[e-mail]> wrote:

It’s fair, and I think in the long term, the implementation should be different.

Right now it is formatted by default. However I think it would be better to have something like that instead:

// In Model, computed and based on static fields fieldNames = { // [Original field name (from client side)]: database field name, flightId: ‘flight_id’, };

This would then allow to override default formatting field names, just as in your case.

Right now, the original field name is lost in translation…as it expects your field name to follow naming conventions. But yes, it might create some confusion in case the name is different.

So two options:

• I can add a comment about this in the documentation
• We can add this now in the code

I just feel a little tired right now, working on this every day. I need a break. So this might have to wait unless you want to work on it, but no pressure.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/eveningkid/denodb/issues/43#issuecomment-640090080, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAY74PUKL2NQBYLSVPIOSIDRVJZEBANCNFSM4NWCMB4Q.