[BUG - Develop] False positives on URL detection
See original GitHub issueDescribe the bug
If someone e.g. says “Awww.” in-game, the pattern www.X
gets picked up as a web address by the text2html parser.
To Reproduce
Steps to reproduce the behavior:
- Open up the webclient for an active game.
emote www.t
- See error
Expected behavior
The URL detection for the text2html parser needs to be reworked to avoid false positives, or possibly removed entirely. I’m of the opinion to remove it entirely. If I take on fixing this, which is likely, that’s the approach I’ll take.
Develop-branch commit
3992f37da
Issue Analytics
- State:
- Created a year ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Address false positives/negatives in Microsoft Defender for ...
A false negative is an entity that wasn't detected as a threat, even though it ... Create an indicator for Microsoft Defender for...
Read more >Incorrect Detection: Report a false positive or false negative to ...
Fill out this form and send a sample file or website for analysis to Bitdefender Labs to rule out a potential incorrect detection:...
Read more >Virus/Malware: TROJ_FRS.VSNTE222
The detection TROJ_FRS.VSNTE222 for the file msedge_200_percent.pak is verified to be False Positive. Our Anti-Malware Team has already released ...
Read more >False detections by Kaspersky products. What to do?
A false detection, or a false positive, is a case of incorrect detection of a clean file or website as infected.
Read more >Vulnerability scans and false positives: the importance of ...
The scanner identifies an input field, which it tests to see if a blind injection attack is possible, inserting input that contains a...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
One reason to do it server side could be parsing URLs into clickable links via MXP for clients that support it.
There’s nothing about URLs specifically, but recognizing an unmarked string of text and deciding to apply formatting to it is very different from converting existing and intentional formatting tags to a different style of formatting tags. Currently, URLs are the only thing that have that kind of process applied - and it’s broken, so the cleanest solution to me is “don’t do it”.
Yeah, if it was done server-side I think this would be the way to do it.