Addpattern with mypy - name already defined

I was going throught the case studies for coconut tutorial and tried using addpattern

def factorial(0) = 1

addpattern def factorial(n is int if n > 0) =
    """Compute n! where n is an integer >= 0."""
    n * factorial(n - 1)

# Test cases:
-1 |> factorial |> print  # MatchError
0.5 |> factorial |> print  # MatchError
0 |> factorial |> print  # 1
3 |> factorial |> print  # 6

Now compiling with coconut fact.coco --mypy yielded

CoconutWarning: missing __init__.coco in package: '...'
Compiling         fact.coco ...
Compiled to       fact.py .
fact.py:39: error: Name 'factorial' already defined on line 23
Found 1 error in 1 file (checked 1 source file)
Exiting due to MyPy error.

The code runs and all but I want to know if this is expected and desired output from mypy?

[FelipeSharkao]

Related to #520, Coconut could add # type: ignore[no-redef] when addpattern is used. For me, ideally, it could be added only when addpattern is used before the function is called, but I guess this is very hard to implement. Maybe include # type: ignore[no-redef] when addpattern is used right on the same file where function was declared.

[evhub]

@EmilRehnberg #510 would not resolve this issue, as even after you give the function a unique name you still need to reassign it if you want it to override the old name. So I think it still makes sense to consider whether Coconut should pass --allow-redefinition by default. I’m going to leave this issue open for that reason.