question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ignore requested_reviewers if PR is approved

See original GitHub issue

Is there a way to ignore requested_reviewers when the PR is approved ?

Example of the issue:

  • PR is opened with a reviewer: prlint ok
  • someone review the pr and approve: prlint ok
  • “update branch” button to merge master in the branch : prlint fail, event if the pr is still approved

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
ewolfecommented, Apr 17, 2018

Off the top of my head, not sure of a way to do this. I can look more into this when I get back from vacation though.

/remind me to look into this issue in 5 days

0reactions
christophehurpeaucommented, Sep 10, 2018

Thank you for your update ! The use case was to force to request someone for a review at the PR creation (or right after) with a message explaining why. The team now took the habit so we don’t really need the rule, even if it would have been nice 😃 Thank you !

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dismissing a pull request review
If your repository requires reviews, you can dismiss pull request reviews that are no longer valid or are unable to be approved by...
Read more >
How to skip reviewer for project administrator pull request?
At least one reviewer must approve the most recent iteration. It's possible to skip review requirement only for project administrators? git ...
Read more >
Approval of required Reviewer does not allow to Complete ...
Hi,. I have a Problem with Azure DevOps, I'm a required reviewer, when I create a PR I can't complete it without adding...
Read more >
Dismissing reviews on Pull Requests
When someone leaves a review that requests changes, dismissing the review changes it from a review that requests changes to a review comment. ......
Read more >
Story of Your Pull Request Being Ignored | by Meng Taing
Why no one reviews your pull request. ... You hope one of them will swiftly approve your one-liner pull request by the ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found