Allow different initial shapes besides rectangle

Useful for initial placeholder actors. If I want to draw a planet, it’d be nice to let Excalibur do it for me vs. me writing custom canvas code. Also, you can’t add an initial color because then Excalibur will draw the rectangle if you call super.draw so you have to start with a null color.

Bonus: Changes shape of bounding box too.

Proposed Actor API

// default
protected defaultDraw(ctx, delta) {
  // draw rect
}

// override
protected defaultDraw(ctx, delta) {
  // custom drawing of shape or default draw
  ex.Drawing.drawCircle(ctx, 5, this.color);
  ex.Drawing.drawEllipse(ctx, 5, 6, this.color);
}

Circle

Assumes width and height are equal (use width / 2)

ctx.beginPath();
ctx.arc(0, 0, this.getWidth() / 2, 0, Math.PI * 2);
ctx.fillStyle = this.color.toString();
ctx.closePath();
ctx.fill();

Ellipse

Uses width / 2 and height / 2

• Scaling circle: http://stackoverflow.com/a/8372834
• ellipse() method

[kamranayub]

Yep, it’s a good idea to open up a work in progress PR so we can keep up with what you’re working on and discuss any questions or design ideas you have!

On Fri, May 4, 2018, 21:54 jedeen [e-mail] wrote:

Yep! Take a look at our updated contributing guide https://github.com/excaliburjs/Excalibur/blob/master/.github/CONTRIBUTING.md, and go ahead!

I’ll assign this issue to myself for tracking. Let us know if you have any questions!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/excaliburjs/Excalibur/issues/562#issuecomment-386774176, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiaa8l_EPbqlFkxMtXu1O7qDE02CP6oks5tvRRVgaJpZM4HK_gd .

[jedeen]

Yep! Take a look at our updated contributing guide, and go ahead!

I’ll assign this issue to myself for tracking. Let us know if you have any questions!