Child entities don't inherit scene from parent, logs warning when killed

It appears that child entities do not inherit this.scene from its parent. I first noticed this when killing an actor with children and getting the following warning:

Cannot kill actor, it was never added to the Scene

After digging into it I noticed it was the child entity logging the warning, as this.scene was null here:

https://github.com/excaliburjs/Excalibur/blob/730d621805d32104c18dc7ca8d9e97c7f212bb2b/src/engine/Actor.ts#L795-L804

If the child entities aren’t truly killed it’s possible this might be a memory leak, but I haven’t dug much further.

Steps to Reproduce

repro: https://codesandbox.io/s/exaclibur-child-entities-bug-5r0w3e?file=/src/index.js

• Add children to an actor via actor.addChild()
• Kill the actor
• See the warning in console

Expected Result

Children should inherit scene from parent and no warning log should occur when killed

Actual Result

Children do not inherit scene and a warning is logged when parent is killed

Environment

• browsers and versions: Chrome 103.0.5060.114
• operating system: macoS 12.4
• Excalibur versions: 0.27

Current Workaround

None

[chrisk-7777]

Thanks for the fix! It’s amazing the speed of development on this project

[chrisk-7777]

I was just about to raise something similar, so good timing!

My suggestion was to improve the warning message to include the actor’s name to help narrow down the warning when it does pop up. But a fix to the underlying issue would also be ace.

Something like:

this.logger.warn(`Cannot kill actor ${this.name}, it was never added to the Scene`);