question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove `.call()` in Timer

See original GitHub issue

Timer’s currently use the .call() to execute their callbacks, this causes some problems because the this is being replaced in the callback context with the Timer’s this

image

Proposal

  1. Replace this section of code with a simple callback, and rename the variable to something better like handler
this._callbacks.forEach((handler) => {
   handler()
});
  1. New unit test required to ensure the “handlers” this is not Timer

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:9 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
eonarheimcommented, Jan 13, 2022

@clinckzone This issue has been stale long enough, it’s all yours now!

@himanshu007-creator Let me know if you’d like a new issue👍

1reaction
himanshu007-creatorcommented, Oct 1, 2021

hi, i would like to work on this issue!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Turn Off Call Timer on Android - YouTube
For Query, Follow & Message Us: https://twitter.com/techieraaj1. Online Typing Job: http://bit.ly/onlinetypingjobonline2.
Read more >
Any way to disable the in-call timer that pops up if using your ...
the incall timer for the LG dialer CANNOT be disabled. your only option is to install a different dialer app and set it...
Read more >
Manage call settings - Android - Google Support
Changing where you get calls doesn't remove a linked number from your account. Open the Voice app "" . In the top left,...
Read more >
Do we need to call DeleteTimerQueueTimer in the Timer ...
Hi,. We need to call DeleteTimerQueueTimer to remove this timer from timer queue. We can have a look at the CreateTimerQueueTimer function. BOOL ......
Read more >
How to stop the task scheduled in java.util.Timer class
Either call cancel() on the Timer if that's all it's doing, or cancel() on the TimerTask if the timer itself has other tasks...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found