Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

errorSplash strings should use interpolation instead of concateration

See original GitHub issue

While working on Korean translation I noticed errorSplash strings are based on concateration approach, which may not work in all languages due to the differences in ordering of words.

I suggest using string interpolation instead of concatenating a variable between pre and post strings.

References

How to concatenate localized strings mindfully by Shopify

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

Rafi993commented, Feb 20, 2021

Hi there since I have been caught up in other things. I’m removing my self as assignee from this issue. Thanks for being awesome 😃

1reaction

dwellecommented, Jan 6, 2021

It’s still unclear to me how we’d interpolate JSX elements, esp with event handlers and such:

https://github.com/excalidraw/excalidraw/blob/778e4b08af13a0e1a4a2a4c8052d51af40c87da3/src/components/TopErrorBoundary.tsx#L115-L131

Top Results From Across the Web

String concatenation vs string interpolation in Python

So when we're concatenating two strings, we're gluing them together by using the + sign. Now, string concatenation is great, but it can...

Is it best practice to use string concatenation or string ...

Answer. String interpolation was a new feature of ES6 - string interpolation, using template literals, allows us to include variables and ...

String concatenation vs. interpolation in Ruby - Stack Overflow

Using "string interpolation" (the second) instead of "string concatenation" (the first):. Pros: Is less typing; Automatically calls to_s for you ...

What is the difference between concatenation and ...

Concatenation allows you to combine to strings together and it only works on two strings. Swift uses string interpolation to include the ...

String interpolation - IBM

Format locale-sensitive information. The following example shows two expressions that would produce the same output, using string concatenation and string ...