Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Massive perf regression

See original GitHub issue

It seems that https://github.com/excalidraw/excalidraw/pull/959 introduced a huge perf regression even for relatively tiny scenes.

target commit https://github.com/excalidraw/excalidraw/commit/35ce1729cc5a122f8924181b6c62448dfd976c12#comments (https://excalidraw-rhlegs9n6.now.sh/) (perf regression)
commit before https://github.com/excalidraw/excalidraw/commit/e1e2249f577d73229902ad23ad76b2c880a39350#comments (https://excalidraw-qgosqln0b.now.sh/)

Test plan:

open each commit & import (drag & drop) these files: perf_test_scenes.zip (includes small scene, and bigger scene)
select all (Cmd + A)
drag the elements around

Before (small scene):

excalidraw_perf_regr_before

After (small scene):

excalidraw_perf_regr_after

Note that there are big perf issues on scenes even smaller than that.

/cc @petehunt

Issue Analytics

State:
Created 4 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

dwellecommented, Mar 17, 2020

props on the fix @petehunt & @vjeux 👍

0reactions

dwellecommented, Mar 17, 2020

We all are 😃. We gotta write them tests!

Top Results From Across the Web

High performance, large-scale regression

This project is looking at the effectiveness of running regression analysis for large datasets with a high number of variables, on distributed computing...

High performance, large-scale regression - YouTube

From 25 June to 14 September 2018, 20 interns worked across nine projects. This series is a compilation of their final presentation.

Massive Performance Regression in Latest Update

Massive Performance Regression in Latest Update ... And there is a huge CPU usage, everything is lagging and freezing after clicking ...

5.4.188 and later: massive performance regression with nfsd

5.4.188 and later: massive performance regression with nfsd @ 2022-05-11 10:03 Wolfgang Walter 2022-05-11 12:38 ` Greg KH 0 siblings, 1 reply; 19+...

Help resolve massive performance regression in 2.7 vs 2.5 ...

How large is self.password_hash? Cheers, Brian. > This comes from "a native Python implementation of the py-bcrypt > package ...