Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

I have an issue storing files on the web server

See original GitHub issue

I’m a big fan of the ExcelDataReader for years, the version I’m using I have re-wrote the zip.worker not to use the file system at all. I posted that code a few years ago on how to not use the temp dir and to create everything in memory. But I see in this version the program is still using the temp dir. What are the opinions from other developers of the risks of a user uploading a virus and than having it saved to web server hard drive versus of it being in memory the whole time where it can be caught in real time by the anti-virus program?

string tPath = Path.Combine(_tempPath, entry.Name);
        string path = entry.IsDirectory ? tPath : Path.GetDirectoryName(Path.GetFullPath(tPath));

        if (!Directory.Exists(path))
        {
            Directory.CreateDirectory(path);
        }

Issue Analytics

State:
Created 8 years ago
Comments:18

Top GitHub Comments

1reaction

prosenbacommented, Mar 22, 2016

Should be there now

Phillip Sent from iPhone

On Mar 22, 2016, at 4:10 PM, Ian1971 <notifications@github.commailto:notifications@github.com> wrote:

I can’t see a pull request. So, assuming you pushed your local changes to your forked repo then go into github and create a pull request.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/ExcelDataReader/ExcelDataReader/issues/104#issuecomment-200073131

0reactions

Ian1971commented, Jun 2, 2016

Sorry you confused my a bit with your question. Is this asking how you should implement your change?