question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking change removing bluebird

See original GitHub issue

Hi, thanks for the great work on this lib.

The removal of bluebird introduce a breaking change. I think the version number of the lib should have changed accordingly.

Indeed, the spread method disappeared.

workbook.xlsx.readFile(file)
.then(() => {
  return Promise.all([
   asyncOpA(),
   asyncOpB()
  ])
})
.spread((resA, resB) => {
  //...
);

TypeError: [...].spread is not a function

I think the use of spread is very common for bluebird users. I my case, my build was broken by this minor version change.

Ideally, we should have the possibility to inject bluebird in ExcelJS to continue to use it.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:4
  • Comments:5

github_iconTop GitHub Comments

1reaction
guyonrochecommented, Feb 21, 2017

Once again - sorry for the break. I have published 0.3.0 with the following two changes:

  • A richer internal Promise implementation (that supports some of the bluebird extras including spread and map)
  • Promise library dependency injection to allow you to restore bluebird if needed.
0reactions
AlexisNocommented, Feb 21, 2017

Awesome! Thank for the quick fix. And again, thanks for the great job on this lib.

Read more comments on GitHub >

github_iconTop Results From Across the Web

New in bluebird 3.0
Summary of breaking changes. Promisifier APIs. Cancellation redesign. Promise progression has been completely removed. .spread 's second argument has been ...
Read more >
Migration from objection 2.x to 3.0 | Objection.js
Here's a list of the breaking changes. Node 6 and 7 are no longer supported; modify method signature change; Bluebird and lodash have...
Read more >
Upgrade to v6 - Sequelize
Below is a list of breaking changes to help you upgrade. ... docs: remove remaining bluebird references #12167; feat(belongs-to-many): allow ...
Read more >
Changelog — funcool/promesa 8.0.450 - cljdoc
This is a breaking change release. Finally bluebird is gone in favour of using the ES6 builtin Promise object. This removes the overhead...
Read more >
@cypress/request-promise - npm
Breaking Change : Removed explicit cls-bluebird dependency which has to be installed by the user now (Thanks to @hildjj for his pull request ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found