Breaking change removing bluebird
See original GitHub issueHi, thanks for the great work on this lib.
The removal of bluebird introduce a breaking change. I think the version number of the lib should have changed accordingly.
Indeed, the spread
method disappeared.
workbook.xlsx.readFile(file)
.then(() => {
return Promise.all([
asyncOpA(),
asyncOpB()
])
})
.spread((resA, resB) => {
//...
);
TypeError: [...].spread is not a function
I think the use of spread
is very common for bluebird users. I my case, my build was broken by this minor version change.
Ideally, we should have the possibility to inject bluebird in ExcelJS to continue to use it.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:4
- Comments:5
Top Results From Across the Web
New in bluebird 3.0
Summary of breaking changes. Promisifier APIs. Cancellation redesign. Promise progression has been completely removed. .spread 's second argument has been ...
Read more >Migration from objection 2.x to 3.0 | Objection.js
Here's a list of the breaking changes. Node 6 and 7 are no longer supported; modify method signature change; Bluebird and lodash have...
Read more >Upgrade to v6 - Sequelize
Below is a list of breaking changes to help you upgrade. ... docs: remove remaining bluebird references #12167; feat(belongs-to-many): allow ...
Read more >Changelog — funcool/promesa 8.0.450 - cljdoc
This is a breaking change release. Finally bluebird is gone in favour of using the ES6 builtin Promise object. This removes the overhead...
Read more >@cypress/request-promise - npm
Breaking Change : Removed explicit cls-bluebird dependency which has to be installed by the user now (Thanks to @hildjj for his pull request ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Once again - sorry for the break. I have published 0.3.0 with the following two changes:
Awesome! Thank for the quick fix. And again, thanks for the great job on this lib.