Cannot remove the last row with .spliceRows()

Hi,

Consider following code:

let Excel = require('exceljs');
let wb = new Excel.Workbook();
let ws = wb.addWorksheet('sheet1');

ws.addRow(['1.1', '1.2', '1.3']);
ws.addRow(['2.1', '2.2', '2.3']);
ws.addRow(['3.1', '3.2', '3.3']);

console.log('rows total: ', ws.rowCount);
for (let i = 1; i <= 3; i++) {
  console.log(i, ':', ws.getRow(i).values);
}

ws.spliceRows(3, 1);

console.log('rows total: ', ws.rowCount);
for (let i = 1; i <= 3; i++) {
  console.log(i, ':', ws.getRow(i).values);
}

Output before splice:

rows total:  3
1 ':' [ , '1.1', '1.2', '1.3' ]
2 ':' [ , '2.1', '2.2', '2.3' ]
3 ':' [ , '3.1', '3.2', '3.3' ]

Output after splice:

rows total:  3
1 ':' [ , '1.1', '1.2', '1.3' ]
2 ':' [ , '2.1', '2.2', '2.3' ]
3 ':' [ , '3.1', '3.2', '3.3' ]

The expectation is that after splice it will be:

rows total:  2
1 ':' [ , '1.1', '1.2', '1.3' ]
2 ':' [ , '2.1', '2.2', '2.3' ]
3 ':' []

Analogy with arrays:

let a = [1,2,3];
a.splice(2,1);
console.log(a); // => [1,2]

[GW-GhostWolf]

Using version 4.2.1, still not fixed. My work around was to add a blank row to the bottom of the worksheet before trying to delete.

lastRow = worksheet.rowCount;
worksheet.insertRow(lastRow + 1,[]);
worksheet.spliceRows(lastRow, 1);

[iva2k]

@GW-GhostWolf Adding just one row may be not enough if number of rows deleted is more than one. Let’s bump it up so the PR is merged.