Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Colab button visible despite no collab entry in _config.yml

See original GitHub issue

Describe the bug

The “Open in Colab” button is visible when Binder is activated, despite having no colab entry in _config.yml

To Reproduce

Steps to reproduce the behavior:

Here is my config: https://github.com/fmaussion/scientific_programming/blob/22ebf73c06a6dc1c4bbc21b0fdfca49ae2086510/book/_config.yml

And the outcome: https://fabienmaussion.info/scientific_programming/welcome.html

Expected behavior

Although it’s not a big deal, I think that the default behaviour should be to not show buttons without entries in the config file.

Environment

Python Version: 3.8
Package versions or output of jupyter-book --version: Jupyter Book: 0.8.2 MyST-NB: 0.10.1 Sphinx Book Theme: 0.0.36 MyST-Parser: 0.12.10 Jupyter-Cache: 0.4.1 NbClient: 0.5.0
Operating System: Linux Mint 20 .

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

choldgrafcommented, Sep 28, 2020

Thanks for reporting! This is weird because I actually opened up a bug about this in sphinx-book-theme (https://github.com/executablebooks/sphinx-book-theme/issues/209) but others said they weren’t able to reproduce the bug so I thought maybe it had been resolved. It seems that it is not!

I think the colab_url is set by default only because there’s just a single possible URL, but I think instead this should be false by default, and have users set it to true to show the colab button.

0reactions

choldgrafcommented, Oct 3, 2020

yeah I agree with both of those points 👍