test suit needs to have jb in $PATH

Test suit is full with lines like

https://github.com/executablebooks/jupyter-book/blob/a3dea447361253199940cf98ea11f413b9fa4194/tests/test_clean.py#L26

the problem with this, is that its assume that jb its on your path, and probably does not make any check to see if its the one you should be testing. this means that if i’m working on a virtual environment, i need to activate the virtual environment. so

~/code/jupyter-book >>> python3 -m venv venv
~/code/jupyter-book >>> ./venv/bin/python -m pip install  .[testing,code_style,sphinx] 
~/code/jupyter-book >>> ./venv/bin/pytest tests

will fail, with

E               FileNotFoundError: [Errno 2] No such file or directory: 'jb'

because jb is not in the path. you actually need to activate the venv

~/code/jupyter-book >>> source ./venv/bin/activate 
~/code/jupyter-book >>> ./venv/bin/pytest tests

that add an extra step that should be necesary

---

a much cleaner way of testing click apps, is use the CliRunner that comes with click. that way the line

run(f"jb clean {path}".split())

can be written like

from click.testing import CliRunner
from jupyter_book.commands import main
 
CliRunner.invoke(main, ["clean", path])

and this can be run without really activating the venv…

if this is ok, i can submit the PR, i just dont wanna do that work if you folks are actively not using clirunner

[chrisjsewell]

Oh indeed, I didn’t write any of this test infrastucture, but was intending to take a hammer to it at some point lol. I’ve used CliRunner plenty e.g. in https://github.com/executablebooks/jupyter-cache/blob/master/tests/test_cli.py

FYI though, you may notice I just added a tox.ini to the repo (9daee14c2cf5e18aa475cee337a9389278682b82), and using that you don’t have to activate any virtual envs (it does it for you 😉)

But yeh, I wouldn’t say no to a PR 😄

[aleivag]

@chrisjsewell seems like it does solve the issue… Thanks!!!