question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Commented tests in TwoferTest Class and possibly one case missing

See original GitHub issue

While doing two-fer I’ve noticed that two positive test cases were commented (not sure why).

    @Ignore("Remove to run test")
    @Test
    public void aNameGiven() {
        String input = "Alice";
        String expected = "One for Alice, one for me.";

        assertEquals(expected, twofer.twofer(input));
    }

    @Ignore("Remove to run test")
    @Test
    public void anotherNameGiven() {
        String input = "Bob";
        String expected = "One for Bob, one for me.";

        assertEquals(expected, twofer.twofer(input));
    }

I guess they shouldn’t be ignored by default.

Moreover, I suggest adding additional one (but not sure if it complies with task description):

    @Test
    public void emptyStringGiven() {
        String input = "";
        String expected = "One for you, one for me.";

        assertEquals(expected, twofer.twofer(input) );
    }

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

3reactions
ilya-khadykincommented, Aug 7, 2017

Sure, will do later today when I get back home

1reaction
stkentcommented, Aug 7, 2017

Might still be worth adding a blank string test to the Java track even though it’s not captured in the canonical data (since it wouldn’t make sense for all languages in the canonical data).

Read more comments on GitHub >

github_iconTop Results From Across the Web

“Two Fer” (One) strings and functions discussion for exercism ...
The class method in the unit test includes an assertion where if no name ... E TypeError: two_fer() missing 1 required positional argument: ......
Read more >
Commented out @Test causes test to fail - Stack Overflow
I.e. the test class does not have a method with @Test annotation anymore. When our continuous integration server runs all tests, it throws...
Read more >
Coverage is missing a class that was in fact tested #193 - GitHub
I ran into a strange scenario today. We're using 0.6.1.201212231917, but I've reproduced the problem on 0.6.4.201312101107 as well.
Read more >
Dealing With Students Missing Exams and In-Class Graded ...
Notify you as soon as possible after missing an exam or required assignment and give the reason? Again, in person or e-mail work...
Read more >
How to Diagnose the Missing Data Mechanism
Missing Completely at Random, MCAR, means there is no relationship between the missingness of the data and any values, observed or missing. Those...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found