Fix Makefile "test-package-files" task

We made a well-intentioned change to our Makefile that tests to see if each exercise has a package.json file that matches the global xecmascript/package.json file, and fails the build if not.

However, there is no easy way for a contributor to update all the package.json files when there is a change. It is critical that these files are all updated, and we want this to happen before PRs are submitted, so the build fails if it is not done.

Two possible solutions:

1. Have the Makefile check its environment. If Travis=true then we’re in CI and should always SKIP copying the package.json files from global to each exercise.
2. Add a task to the Makefile that would let contributors copy the package.json file to all exercises, EG make copy-package-to-exercises.

Either approach probably warrants a small update to the contributor docs.

Success Criteria:

• Builds fail on Travis if package.json files are not the same in each exercise as the global.
• Contributors have a simple way to make sure their PRs are ready for CI testing.
• Documentation is updated.

[rchavarria]

I prefer taking the second way, adding the new copy-package-to-exercises task.

I’m wondering if we need a new task to be able to build the project, to run tests independently of copying package.json or checking them.

Let’s say we have these tasks:

• make test: it should just run tests, no package.json checking, no package.json copying
• make copy-package-to-exercises: easy to understand
• make build: it could check package.json equality and run tests.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.