Improve Practice Exercise "Promises"
See original GitHub issueI was trying to help a student but the exercise makes no sense to me. If I implement just a TINY implementation:
export const promisify = (fn) => {
return (v) => {
return new Promise(() => {
});
};
};
All the tests start turning green, despite the fact that I’m not even calling fn
, not rejecting or resolving anything… if I can’t trust the test suite to guide me then I’m not sure how any student is supposed to get thru this complex exercise.
If the function we’re supposed to be wrapping is of the form fn(...args, (error, result) => {})
then that should probably be mentioned somewhere in the instructions, perhaps with examples of before/after, etc.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (7 by maintainers)
Top Results From Across the Web
JavaScript: Run a given array of promises in series - w3resource
JavaScript fundamental (ES6 Syntax) exercises, practice and solution: Write a JavaScript program to run a given array of promises in series.
Read more >Promises in JavaScript on Exercism
Ready to start Promises? Sign up to Exercism to learn and master JavaScript with 32 concepts, 140 exercises, and real human mentoring, all...
Read more >The Promise of Mindfulness Practice
Mindfulness has some incredible benefits that can help you better understand and cope with your emotional responses and the world around ...
Read more >Promises Cheatsheet - Learn JavaScript - Codecademy
A JavaScript Promise object can be in one of three states: pending , resolved , or rejected . ... This is better practice...
Read more >How to Get Good Promises from Your Team and How to ...
What it takes to develop good relationships and make great promises · New Practices: The skills I'm pointing to above are not skills...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
The tests are now fixed and the exercise is hidden. I am keeping the issue open since the task of fixing the instructions/ the exercise itself is still open.
That’d be great. Happy to review new instructions when they are ready and give this another shot to see if it could be improved further.