Robot Name Test case there can be many robots

https://github.com/exercism/xecmascript/blob/master/exercises/robot-name/robot-name.spec.js#L28

This test is assuming global state of usedNames. In JS5 this this the way it is because var is global. I don’t think that should be the case for ES6+. I think part of it is that the class name is Robot instead of RobotName. Something like usedName or similar should be encapsulated inside the class to avoid global state.

related: https://github.com/exercism/xjavascript/issues/105 https://github.com/exercism/xjavascript/blob/master/exercises/robot-name/robot-name.spec.js#L35

[kotp]

@rchavarria said:

I don’t know if users can submit several files

from this comment

I just wanted to answer “yes” to that doubt. It is possible. Here is an example of doing such a thing.

[kotp]

I think since the practitioner is going to edit the tests, they are likely to comment out the skips as they are used to doing, they are going to be in that file, when their tests fail, and that test doesn’t look like the others, they are likely to read the comments. Or at least more likely, at that point.

People are funny though, sometimes they can’t see the ketchup in the door for the ketchup on the second shelf of the fridge.