Errors in: Leap

Common problems also found in other tests.

1. Problem description too vague: Given a year, report if it is a leap year.

• function/class?
• name?
• file name?
• return type?
• restrictions?

=> the user has to guess what to do, from the test suite.

1. Test suite is incomplete, most tests are skipped because of @Ignored tags.

=> test unreliable

class LeapTest {

    @Test
    fun yearNotDivisibleBy4() {
        assertFalse(Year(2015).isLeap)
    }

    @Ignore
    @Test
    fun yearDivisibleBy4NotDivisibleBy100() {
        assertTrue(Year(1996).isLeap)
    }

    @Ignore
    @Test
    fun yearDivisibleBy100NotDivisibleBy400() {
        assertFalse(Year(2100).isLeap)
    }

    @Ignore
    @Test
    fun yearDivisibleBy400() {
        assertTrue(Year(2000).isLeap)
    }

}

[mikegehard]

I’m closing this issue for now. If the two discussions above don’t solve this for you, please start a discussion here and we can try to find a solution together.

[mikegehard]

Thanks for the report. #2 should be addressed in #296. Each assignment description will let folks know to remove the @Ignore. Hopefully that helps once it is deployed to prod. If it doesn’t, please let me know.