[Crypto Square] exercise is lacking a test for empty text after normalized
See original GitHub issueFor exercise Crypto Square there is no test case for plaintext made up of just spaces and punctuation.
There are tests for normalized input - one for removing spaces, and one for removing punctuation, but not for the case text is empty after normalized. Mentored someone with code that pass all tests, but have a bug in this case, so wanted to add this.
I’m new to to exercism github contribute, so not sure about a lot of stuff… I saw in another issue that test maybe taken form problem-specifications repo, so I posted a PR there: https://github.com/exercism/problem-specifications/pull/2129 But if test for Python track should be PRed here, please tell me.
My original intention was to update: https://github.com/exercism/python/blob/main/exercises/practice/crypto-square/crypto_square_test.py by adding this code to CryptoSquareTest class
def test_empty_plaintext_after_normalized(self):
value = "... --- ..."
expected = ""
self.assertEqual(cipher_text(value), expected)
Issue Analytics
- State:
- Created a year ago
- Comments:6 (4 by maintainers)
Top GitHub Comments
I just became the third approver. I’ve also merged it in. Thanks again for the PR! ⭐ 🌈
@BethanyG – Thanks for your good intentions! There is no rush, so only if and when you’ll have free time. BTW, there are already 2 approvals for the PR.