question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Crypto Square] exercise is lacking a test for empty text after normalized

See original GitHub issue

For exercise Crypto Square there is no test case for plaintext made up of just spaces and punctuation.

There are tests for normalized input - one for removing spaces, and one for removing punctuation, but not for the case text is empty after normalized. Mentored someone with code that pass all tests, but have a bug in this case, so wanted to add this.

I’m new to to exercism github contribute, so not sure about a lot of stuff… I saw in another issue that test maybe taken form problem-specifications repo, so I posted a PR there: https://github.com/exercism/problem-specifications/pull/2129 But if test for Python track should be PRed here, please tell me.

My original intention was to update: https://github.com/exercism/python/blob/main/exercises/practice/crypto-square/crypto_square_test.py by adding this code to CryptoSquareTest class

def test_empty_plaintext_after_normalized(self):
    value = "... --- ..."
    expected = ""
    self.assertEqual(cipher_text(value), expected)

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
BethanyGcommented, Oct 14, 2022

I just became the third approver. I’ve also merged it in. Thanks again for the PR! ⭐ 🌈

0reactions
izmirlicommented, Oct 13, 2022

@BethanyG – Thanks for your good intentions! There is no rush, so only if and when you’ll have free time. BTW, there are already 2 approvals for the PR.

Read more comments on GitHub >

github_iconTop Results From Across the Web

MartinBuchmann's solution for Crypto Square in Common Lisp ...
Learn from how MartinBuchmann solved Crypto Square in Common Lisp, and learn how others have solved the exercise.
Read more >
Consistency between tests in example implementation and ...
A typical exercise implementation for the D track has two .d files: Example implementation NOT served to students. Used in CI to make...
Read more >
Informatica Scenario Based Interview Questions in 2023
This blog covers scenario based Informatica interview questions & ETL interview questions for 2023 that will help you ace your job ...
Read more >
CREAK Data Explorer
Only people named Floyd wearing pink are allowed to attend Pink Floyd concerts. Marlboro used iconic imagery to promote its brand. Fax works...
Read more >
RFC 3986: Uniform Resource Identifier (URI): Generic Syntax
Examples The following example URIs illustrate several URI schemes and variations ... the "http" scheme considers a missing authority or empty host invalid....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found