Two-Fer exercise recommends against input validation.

My solution to the Two-Fer exercise included a test for isinstance(name, str), and the analyzer states that conditionals are used unnecessarily. This could be a completely preferential thing and I’m just over-engineering, but I feel like input validation shouldn’t be considered “unnecessary.”

If I’m wrong about this, at least I’ll have learned something haha

[piccoloser]

I think that should do it; I appreciate the info and quick response!

[BethanyG]

@piccoloser

You are most welcome!. And all that being said – I can clearly see why you’d want to be suspicious if you were taking in “random” user input. (users are creative and terrible engines of chaos!). Certainly something to think through if this was part of a larger program or was a method designed to interact with an entry screen. Also something to really think through if the string you are building and passing back is intended for a downstream process to act on. That recent log4J bug is no joke – and neither are un-sanitized DB inputs. 😉

When I used to mentor this problem a lot, I would refer to this post on Real Python, I love how he breaks down the reasoning behind the different string formatting options and goes over benefits and pitfalls.

Thanks again for logging this. I will keep it open for a bit and then close – unless you have other questions or issues?