Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Deprecated directive is missing from the schema

See original GitHub issue

Library Version latest snapshot

Describe the bug @deprecated directive is no longer applied to the schema

Screen Shot 2019-07-01 at 8 33 38 AM

To Reproduce Run example app and check generated schema - it contains 5 directives (custom @lowercase, @stringEval and @cakeOnly as well as @skip and @include built-in ones).

Expected behavior Schema should contain @deprecated directive as some fields (e.g. simpleDeprecatedQuery are deprecated)

Issue Analytics

State:
Created 4 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

2reactions

dariuszkuccommented, Jul 1, 2019

@deprecated directive is pretty special in a sense that it is just informational as there is no associated RuntimeWiring behind it that would customize it behavior.

I was thinking that we could add explicit support for it (as well as the ability to customize the behavior) by doing something along those lines -> https://github.com/ExpediaDotCom/graphql-kotlin/pull/247

0reactions

dariuszkuccommented, Jul 1, 2019

It appears that there are multiple potential issues

playground related issues 339 and 816 - currently playground doesn’t handle deprecated well (as compared to graphiql), this is what actually started this investigation
graphql-java related issue 1434 - currently graphql-java filters out “common” directives (skip, include, defer and deprecated) from printing in SDL.
graphql-java also only adds the deprecated directive to the schema when manually loading it from the file (e.g. here -> https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/idl/SchemaGenerator.java#L265)
graphql-java adds @depreacted directives directly to instrumentation results (e.g. here https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/introspection/IntrospectionResultToSchema.java#L237)

Top Results From Across the Web

What is up with schema directives right now? - Apollo GraphQL

Looking at the documentation for @graphql-tools , it states a general Schema Directive pattern that relies on using transforms, and in the ...

graphql-directive-deprecated - npm package - Snyk

A GraphQL schema directive for deprecating fields For more information about how ... Looks like graphql-directive-deprecated is missing a security policy.

Adding directives to the schema in code-first GraphQL servers

Contrasting schema- and query-type directives @deprecated is a schema-type directive, so it must be applied on the schema. However, what would ...

Learn Sangria

@addSpecial directive needs to add new field in the Query type. For all other fields in the schema we need to define default...

Combining Schemas – GraphQL Tools

... merged types, and declarative schema directives. ... Having a subschema return null without an error for missing or failed records is a ......