[$250] Mac / Firefox - Composer height increases on adding emoji reported by @daraksha-dk
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open a chat
- Add emoji to the message composer
Expected Result:
Composer height should not increase
Actual Result :
Composer height increases
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web - Mac / Firefox
Version Number: v1.2.28
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Upwork URL: https://www.upwork.com/jobs/~01275834e00548fe27 Issue reported by: @daraksha-dk Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668510274384019
Issue Analytics
- State:
- Created 10 months ago
- Comments:28 (24 by maintainers)
Top Results From Across the Web
Emoji – Get this Extension for 🦊 Firefox (en-US)
Download Emoji for Firefox. It permits just with a single click to copy an emoji. There is a search-box and the "Most used...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Nice find. Would each browser use a different default though?
@trjExpensify a quick look, you can reproduce in the edit input too , the
scrollHeight
for emojis in Firefox is greater thanlineHeight
this will make number of rows = 2 for first inputThe solution is to increase
lineHeight
to match the scrollHeight , but make sure to run tests against any changes when editing the compose styles as it is easy to introduce regressionshttps://github.com/Expensify/App/blob/12dd4c6ea78e2454938ca9bf720d4e1b64d31ef0/src/styles/styles.js#L1396
Test Firefox
Before
After