question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[$250] Mac / Firefox - Composer height increases on adding emoji reported by @daraksha-dk

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Add emoji to the message composer

Expected Result:

Composer height should not increase

Actual Result :

Composer height increases

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web - Mac / Firefox

Version Number: v1.2.28 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Screen Shot 2022-11-15 at 2 39 27 PM

https://user-images.githubusercontent.com/43996225/202010791-3747c86d-cda0-47a7-a982-44efb7211f39.mov

Upwork URL: https://www.upwork.com/jobs/~01275834e00548fe27 Issue reported by: @daraksha-dk Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668510274384019

View all open jobs on GitHub

Issue Analytics

  • State:closed
  • Created 10 months ago
  • Comments:28 (24 by maintainers)

github_iconTop GitHub Comments

2reactions
Julessssscommented, Nov 16, 2022

The scrollHeight for emojis in Firefox is greater than lineHeight

Nice find. Would each browser use a different default though?

2reactions
fedirjhcommented, Nov 16, 2022

@trjExpensify a quick look, you can reproduce in the edit input too , the scrollHeight for emojis in Firefox is greater than lineHeight this will make number of rows = 2 for first input

Screenshot 2022-11-16 at 2 10 41 AM Screenshot 2022-11-16 at 2 14 22 AM

The solution is to increase lineHeight to match the scrollHeight , but make sure to run tests against any changes when editing the compose styles as it is easy to introduce regressions

https://github.com/Expensify/App/blob/12dd4c6ea78e2454938ca9bf720d4e1b64d31ef0/src/styles/styles.js#L1396

-        lineHeight: 20,
+        lineHeight: 21,

Test Firefox

Before

Screenshot 2022-11-16 at 2 28 10 AM

After

Screenshot 2022-11-16 at 2 27 50 AM
Read more comments on GitHub >

github_iconTop Results From Across the Web

Emoji – Get this Extension for 🦊 Firefox (en-US)
Download Emoji for Firefox. It permits just with a single click to copy an emoji. There is a search-box and the "Most used...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found