Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Apply localization to all hard coded text in the Expensify.cash app

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Upwork job - https://www.upwork.com/jobs/~01ad599888651ad174

Expected Result:

We are looking to apply localization to the Expensify.cash app, so that all hard coded text is replaced with locale-aware components/ methods. This project will require (1) Identifying all places that display hardcoded texts in the app, and (2) Using the withLocalize HOC in this PR https://github.com/Expensify/Expensify.cash/pull/2208 to make all those texts support localized versions.

Actual Result:

Today, all text in the Expensify.cash app is hardcoded in English. Here are a few examples for reference:

Platform:

This should apply to all platforms listed:

Web
iOS
Android
Desktop App
Mobile Web

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/152153

Other considerations:

There may be a few areas where it doesn’t make sense to translate hardcoded text, which are important to highlight as a part of this project. For example, we should not update the hard corded text found here:

Click avatar (above chat list) > Profile > Set my time zone manually > see dropdown list of regions

Issue Analytics

State:
Created 2 years ago
Comments:36 (36 by maintainers)

Top GitHub Comments

2reactions

eVoloshchakcommented, Apr 21, 2021

The only one I am having doubts is this one, is that actually printed in screen for the user to see?

Judging by the source code it is visible to user on the screen, but I will have to double check when I actually launch the application.

Feel free to begin drafting a PR for the proposed solution. Given that this is your first time working on an Expensify.cash job, I wanted to highlight the [Contributor Guidelines] (https://github.com/Expensify/Expensify.cash/blob/master/CONTRIBUTING.md) in case you haven’t read it yet!

Starting to work on the PR, thank you for the guidelines

so can’t we set the key as CONST values and thus they would be passed down.

Got it

1reaction

eVoloshchakcommented, May 6, 2021

@eVoloshchak can you confirm you are working on this?

Yes, I’m working on this, planning to submit a PR in a couple of hours.

P.S: submitted a new PR. https://github.com/Expensify/Expensify.cash/pull/2718

Top Results From Across the Web

How to localize your Android App Tutorial - Babble-on

Step-by-step Android localization. 1. First, identify the texts to be translated. These are your user-facing text labels, buttons, and other visible parts ...

Page 9 | Expensify Reviews - Pros & Cons, Ratings & more

Page 9 - See the latest verified ratings & reviews for Expensify. Compare real user opinions on the pros and cons to make...

FORM 10-K - Expensify, Inc

Indicate by check mark whether the registrant (1) has filed all reports required to be filed by Section 13 or 15(d) of the...

5 Most Expensive Game Localization Mistakes

#1: Embedding text into the game's core files ... One of the most costly mistakes we often see is text being hard-coded into...

How do I translate my hard-coded strings in swift 2.0? [duplicate]

the hard coded text would change to another language this is called localization. so you have to implement localization in your project.