[GH Actions] Request review of automerge PR if there is a merge conflict
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding!
Problem
Typically, PRs that have the automerge
label don’t need to be manually reviewed by anyone. In those cases, we don’t want to request a review. However, since we’ll be using automerge
PRs to CP PRs to staging and/or production, we’ll have more cases where it can’t be automatically merged because of a merge conflict. In these cases, we need to request a reviewer on the PR so that the reviewer can manually resolve the merge conflict.
Why is this important?
This will be a pre-requisite of our Expensify.cash CP flows.
Solution
If this step of the automerge
workflow exits with a nonzero exit code, add pullerbear
as a reviewer on the PR.
Apply to this posting on Upwork: https://www.upwork.com/jobs/~01977821838810f422 https://github.com/Expensify/Expensify/issues/155154
Issue Analytics
- State:
- Created 3 years ago
- Comments:7 (7 by maintainers)
Top GitHub Comments
Sending over an offer in Upwork now, @mikeattara .
Update Currently, all pull requests require at least one approving review to be merged so I added a check on the
automerge workflow
formergeability
andmergeable_state
.NB:
Expensify/pullbearer
is automatically added as a reviewer for all pull requests.