[Hold for payment 2021-08-05] Fix padding, bolding, and text wrapping behavior of the "It's HH:MM for XXXX" blurb
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Navigate to a conversation that has some existing messages.
Expected Result:
We’d like to tweak three things in this issue:
-
Fix the padding between the
It's HH:MM for XXXX
blurb and the most recently sent DM. -
Fix text wrapping behavior of
It's HH:MM for XXXX
when it’s a long string. -
Remove all bolding from the
It's HH:MM for XXXX
andXXXX is typing...
Actual Result:
- There’s unbalanced amount of padding between the
It’s HH:MM for XXXX
blurb and the latest message in chat - Long strings don’t text wrap properly when the
It's HH:MM for XXXX
blurb is long. - We use too much bold text in (i)
It's HH:MM for XXXX
and (ii)XXXX is typing...
Workaround:
None needed, these are small UI improvements
Platform:
Where is this issue occurring? All platforms
Version Number: 1.0.77-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Upwork job link: https://www.upwork.com/jobs/~01d5b5dac390b97161
From @twisterdotcom https://expensify.slack.com/archives/C01GTK53T8Q/p1626083700113600
A bit too much padding/empty space between “It’s TIME for USER” and the latest message:
Issue Analytics
- State:
- Created 2 years ago
- Reactions:2
- Comments:19 (15 by maintainers)
Excellent work @parasharrajat.
Thanks Beamanator – I had this open as a tab to update the GH like you did 🏆 .
Agreed and payment due in 2 day, assuming no regressions appear.
Adding myself & assigning to appropriate people & adding correct labels
Looks like the PR was merged 5 days ago with no regressions so far 👍