[HOLD for payment 2022-12-20] Connect bank account - The green option row and standard option row don’t line up correctly & icons and text are not aligned
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to workspace setting
- Click
Connect back account
- Observe the green option row and standard option row
- Hover over the
connect manually
Expected Result:
There should be no alignment issue and should be full rounded pill shape
Actual Result:
The green option row and standard option row don’t line up correctly, the icons and text are not perfectly aligned and the hover style should use the full rounded pill shape as well
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- Desktop App
Version Number: v1.2.36 -1 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670023956657779
Issue Analytics
- State:
- Created 10 months ago
- Comments:11 (7 by maintainers)
Top GitHub Comments
@kevinksullivan since this wasn’t really a bug, just something that didn’t fully change as much as it should have in the redesign, I don’t think we need a regression test - that is, this was not a regression, but open to your thoughts (and checks in the checkbox haha)
@kevinksullivan I’m going to grab this and take it internal since I introduced it in the first place haha. Should be a pretty quick fix.