question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[HOLD for payment June 29] Update compose box to send photos and text in one message

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

  1. When uploading image attachments in Expensify.cash, the existing attachment preview modal should appear. Instead of saying “Upload”, it should now say “Send”.

This should work the same for all three modes of interaction: - Manually picking an image using the AttachmentPicker, - Drag-and-dropping a photo into the ReportActionCompose, - Pasting a photo into the ReportActionCompose from the platform’s native clipboard.

  1. After hitting “Send”, any draft text in the composition box should be sent, followed by the attached image below the text.

@mallenexpensify @shawnborton if you have nothing else to add here then feel free to apply the External label so we can get this on Upwork.

Actual Result:

  • Image uploads and text in compose box persists.

Action Performed:

Web/Desktop

  • Type text in compose box
  • Drag/drop image to compose box to upload
  • Click 'Upload`

Mobile web/app

  • Type text in compose box
  • Tap attachment/paperclip icon
  • Tap Photo Library or Choose from Gallery
  • Select photo and tap Choose or Upload to upload

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/156214 Platform - version: All

Notes/Photos/Videos: Big ol’ thread in Slack - link iOS/Messenger is what we’re wanting to mimic IMG_5636

IMG_5637

Slack does a good job of handling this but they put they post the text above the image. image

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:38 (36 by maintainers)

github_iconTop GitHub Comments

1reaction
parasharrajatcommented, Jun 30, 2021

Done

1reaction
roryabrahamcommented, Jun 21, 2021

Nice, proposal looks good to me @parasharrajat 👍

Read more comments on GitHub >

github_iconTop Results From Across the Web

Apple unveils new ways to share and communicate in iOS 16
iOS 16 introduces iCloud Shared Photo Library to seamlessly share a collection of photos with family, updates to Messages and Mail that help ......
Read more >
62 professional text message examples for businesses - Textline
1. Scheduling a call with new lead · 2. Following up with a lead who requests a price quote · 3. Thank you...
Read more >
View text messages sent and received free - CasaClima
View Date & Time of Text Messages On iPhone. No need to register, just write your message and send text message to any...
Read more >
Ticket: # 705801 - unsolicited email advertising Description
I received an unwanted phishing text message from an email address. It reads, "Did you pick up any shares of SRCF?
Read more >
Instagram Story Hacks: 32 Tricks and Features You Should ...
If you start off creating a post with an image, add a text box on top and type your hashtags and mentions. With...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found