[Hold WAQ] Extend “archive” pattern to DMs

If you haven’t already, check out our contributing guidelines for onboarding and email [e-mail] to request to join our Slack channel!

---

Coming from this Slack conversation

Problem

Active accounts in DMs with closed accounts can still send messages and money requests, despite the closed accountholder explicitly taking the action to close their account. When this happens the closed accountholder receives the unread messages email summary delivered via the NotifyOfflineUsersAboutActivity job, just like they would if they still had an active account. This creates a confusing experience for 1) the person that actively closed their account that doesn’t expect to continue to receive messages and money requests after taking that action and 2) the active accountholder who’s unaware that the other participant doesn’t intend to respond or pay them back.

Solution

Extend our “archived” chat pattern used for rooms and workspace chats to DMs, such that the ability to send additional messages or request money within the DM is no longer possible after a participant has explicitly closed their account.

1. The chat name will show as archived in the UI i.e Tom Rhys Jones (archived)
2. The archivedReason text box that blocks further chat input explains it i.e This chat is archived because **Tom Rhys Jones** has closed their account.
3. If the closed accountholder reopens their account the chat is unarchived (similar to how we archive/unarchive a policyExpenseChat when a member is removed/re-added to a policy).

View all open jobs on GitHub

[trjExpensify]

Yeah, I thought we already agreed in the thread to put this part on hold. I’m updating the title to reflect that.

[JmillsExpensify]

I’m still on the fence as to whether this is a WAQ initiative, or whether it’s scope for N7. So for instance, building on the discussion in Slack, I absolutely agree that we should decline/cancel IOUs when someone closes their account. That is what’s causing bugs. This however, is more of a polish item helping people understand whether a person is or isn’t available (because their account is closed). Accordingly, I would default to putting this on HOLD for after WAQ. Curious for thoughts on this!