Images not uploading when you hit return immediately after pasting

If you haven’t already, check out our contributing guidelines for onboarding!

---

Expected Result:

• The Image should upload

Actual Result:

• The image doesn’t upload and the upload attachment modal closes

Action Performed (reproducible steps):

• Copy an image to clipboard
• Click on compose box in chat with user or test account
• Paste image into compose by by typing command+v
• immediately tap enter twice or more.
• Observe image doesn’t upload

Workaround:

Wait a couple of seconds before hitting enter.

Platform:

Desktop App

Version Number: Desktop v.2-52 Notes/Photos/Videos: https://user-images.githubusercontent.com/22508304/111228887-35476680-85a2-11eb-970c-518ba9fdb640.mp4 **Expensify/Expensify Issue URL:**https://github.com/Expensify/Expensify/issues/157267 Upwork URL: https://www.upwork.com/jobs/~016727690d69f1c182

[parasharrajat]

@marcaaron. Yes the solution still works without moving the keyboard events to onModalWillShow. So after pasting the image and pressing enter will not cancel the attachment Modal. But the Image will not be submitted until the modal is shown and then on pressing Enter the image will be submitted.

Updating the proposal to reflect this scenario.

[marcaaron]

These handlers are the one who submits the image. So they should be ready as early as possible. onModalShow fires after the modal are completely visible and the animation has finished thus pressing the enter won’t work immediately. Moving handlers to the onModalWillShow, make them available as soon as modal is rendered and modal comes into the visible state before animations and all those things are started.

Ok, that doesn’t sound like an optimization we need. The modal shows very quickly.

Sorry, but I didn’t get this. What check?

if (e && e.type === 'keydown' && e.key === 'Enter') {