question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Improvement] Improve E.cash search for group chats

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding!


Platform - version: All

Problem

Search is frequently how I find a given chat. There are two main problems I currently have with it:

  1. It doesn’t work well for group chats. For example I can’t type in Lauren Andrew in order to find my group chat with Lauren and Andrew.
  2. It looks for the whole string that I type in to be a match, rather than looking at whether there is a matching user for each word. For example, when I search Alex Revelli nothing comes up because she she is listed as Alexandra Revelli. I would think that she would still show up because the second word in my search, Revelli is a match to her user.

Why is this important?

Easy search makes Expensify.cash an easier, lighter experience.

Solution

Update search to work as follows:

  • split search string on spaces
  • return all exact and partial matches to each string
  • order results by most recent message (meaning the most recent message posted in the chat)

Upwork Job link: https://www.upwork.com/jobs/~01ccd27d2ef43f2d7f

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
tugbadogancommented, Feb 14, 2021

Hi @NicMendonca, I created a pull request on top of the most recent UI changes. I fixed this issue and removed redundant regex patterns from the code.

1reaction
tugbadogancommented, Feb 1, 2021

Hi @NicMendonca,

I’ve already apply through Upwork. My Upwork name is Fadime Tugba Oge.

Also a note, we’re waiting for other UI changes before we can hire for this job.

No problem, thanks for letting me know. I’m happy to work on this issue later.

Read more comments on GitHub >

github_iconTop Results From Across the Web

A New Chat Bot Is a 'Code Red' for Google's Search Business
Many experts believe Google will continue to take this approach, incrementally improving its search engine rather than overhauling it. “Google ...
Read more >
e-cash.pdf - FinCEN
cash, electronic banking, and Internet gaming. This initiative was undertaken within the context of FinCEN's mission to support and strengthen domestic and ...
Read more >
eCash Money - Try our Mobile Wallet by Due Cash
Our free ecash mobile wallet allows you to send money and receive money instantly for your business. Money deposits directly to your bank...
Read more >
The keys to a successful digital transformation | McKinsey
Looking ahead. While respondents say that many digital transformations fall short in improving performance and equipping companies to sustain ...
Read more >
Create effective Search ads - Google Ads Help
Official guide to optimizing ads and messaging on Google Search Ensure you do these 2 things: Implement at least one responsive search ad...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found