question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Markdown link eats end parenthesis

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding!


Platform - version: All - reproducible on v1.0.1-439

Action Performed (reproducible steps):

  • Log into https://expensify.cash/
  • Start chatting with another user
  • Send a message in parenthesis with a hyperlink in markdown that has a / at end of URL eg ([google](https://google.com/))

Expected Result: For the URL in parenthesis to hyperlink and for the bracket to close (google)

Actual Result: the last parenthetical bracket doesn’t appear - image

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:20 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
minbaghdasaryancommented, Mar 4, 2021

We can fix the issue by updating ExpensiMark in expensify-common node module. I thought that ExpensiMark is used everywhere, but I can’t confirm same issue happens everywhere ExpensiMark is used, and that’s why I worried making changes on ExpensiMark will break expected behavior on other places where ExpensiMark is used. Thanks for letting know and I can fix the issue forward by fixing the ExpensiMark.

0reactions
minbaghdasaryancommented, Mar 4, 2021

Thanks @laurenreidexpensify I approved the refund request already. But the review is very important for me to get new jobs, and I want to cry at the moment. Please help me to change the review?

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do you write a link containing a closing bracket in ...
I have found that using < around > the url seems to solve the problem. In the two internal systems we use that...
Read more >
URL with multiple ending parentheses produces broken links ...
Test of link in MarkDown rendering. - Use your URL and Button above. Test of link using brackets and parentheses. - Duplicate your...
Read more >
Basic Syntax - Markdown Guide
Formatting Links. To emphasize links, add asterisks before and after the brackets and parentheses. To denote links as code, add backticks in the...
Read more >
markdown-guide/links.md at master - GitHub
To create a link, enclose the link text in brackets (e.g., [Duck Duck Go] ) and then follow it immediately with the URL...
Read more >
Using URLs with Parenthesis in Markdown Links - DayOneApp
Some URLs contain parenthesis which can cause problems with Markdown links. To workaround this issue, “escape” the URL with a backslash.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found