Merge conflicts in CP PRs are not handled well
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Create a PR with changes in a given file.
- Give the PR the
CP Staginglabel. - Merge the PR.
- Create another PR with changes in the same file (to ensure that there will be conflicts on staging).
- Give the PR the
CP Staginglabel. - Merge the PR.
- The CP PR created for the second PR will be created but not automerged, due to conflicts.
Expected Result:
- The CP PR should be auto-assigned to the author of the original (second) PR.
- PR checks (lint, test, etc…) should run on the CP PR.
Actual Result:
- The PR was not auto-assigned.
- PR checks did not run on the CP PR, even after manually pushing new code to the PR.
Workaround:
n/a
Platform:
GitHub only
Version Number: 1.0.77-2
Issue Analytics
- State:
- Created 2 years ago
- Comments:10 (8 by maintainers)
Top Results From Across the Web
Question: How to manage merge conflicts with MAC signature ...
Hi. Great stuff here. Putting a PoC together for the team using git as a storage and distribution mechanism.
Read more >How can a developer overcome their fear of merge conflicts?
Make small PRs/commits; Just make tiny adjustments. The smaller the changeset, the less merge conflicts can exists in the first place.
Read more >How to Prevent Merge Conflicts (or at least have less of them)
Merge conflicts are mostly inevitable. You will experience more than one merge conflict in your career, but with good communication and ...
Read more >How do I resolve merge conflicts in a Git repository?
Try: git mergetool. It opens a GUI that steps you through each conflict, and you get to choose how to merge. Sometimes it...
Read more >How to Resolve GitHub Merge Conflicts | Cloudbees Blog
GitHub merge conflict: How to handle the most common merge ... Not too long after Git and GitHub emerged, this question appeared on...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

Will work on this next week
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀