question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Merge conflicts in CP PRs are not handled well

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a PR with changes in a given file.
  2. Give the PR the CP Staging label.
  3. Merge the PR.
  4. Create another PR with changes in the same file (to ensure that there will be conflicts on staging).
  5. Give the PR the CP Staging label.
  6. Merge the PR.
  7. The CP PR created for the second PR will be created but not automerged, due to conflicts.

Expected Result:

  1. The CP PR should be auto-assigned to the author of the original (second) PR.
  2. PR checks (lint, test, etc…) should run on the CP PR.

Actual Result:

  1. The PR was not auto-assigned.
  2. PR checks did not run on the CP PR, even after manually pushing new code to the PR.

Workaround:

n/a

Platform:

GitHub only

Version Number: 1.0.77-2

View all open jobs on Upwork

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
HorusGoulcommented, Jul 23, 2021

Will work on this next week

0reactions
botifycommented, Sep 4, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
Read more comments on GitHub >

github_iconTop Results From Across the Web

Question: How to manage merge conflicts with MAC signature ...
Hi. Great stuff here. Putting a PoC together for the team using git as a storage and distribution mechanism.
Read more >
How can a developer overcome their fear of merge conflicts?
Make small PRs/commits; Just make tiny adjustments. The smaller the changeset, the less merge conflicts can exists in the first place.
Read more >
How to Prevent Merge Conflicts (or at least have less of them)
Merge conflicts are mostly inevitable. You will experience more than one merge conflict in your career, but with good communication and ...
Read more >
How do I resolve merge conflicts in a Git repository?
Try: git mergetool. It opens a GUI that steps you through each conflict, and you get to choose how to merge. Sometimes it...
Read more >
How to Resolve GitHub Merge Conflicts | Cloudbees Blog
GitHub merge conflict: How to handle the most common merge ... Not too long after Git and GitHub emerged, this question appeared on...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found