Move Search to the RightDockedModal
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding!
view the job on upwork here.
Platform - version:
current
Currently, clicking the search icon changes the functionality of the Left Hand Nav in order to show search results. We’ve recently introduced a right-docked modal which would be a better fit for search functionality. We’re leaving the search icon in the same place as it is today (on the left), but we’re going to engage the right-docked modal to show the search bar and search results when the icon is clicked. This implementation is similar to NewChatPage
and NewGroupPage
navigation wise.
Action Performed (reproducible steps):
- Click the search icon
- Search for a user using the search bar
Expected Result:
- The search bar and results should utilize
RightDockedModal
Note: ensure we grey out the main page content, as we do for the other pages in theRightDockedModal
Actual Result:
- The search bar and results utilize the Left Hand Nav
Notes/Photos/Videos:
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
How To Move Safari Search Bar To The Top - iOS 15, iPhone ...
This quick iPhone tip will show you how to move Safari search bar to the top on iOS 15. Previously with iOS 14...
Read more >How to Move Safari's Search Bar Back Where It Belongs in ...
How to Move Safari's Search Bar Back Where It Belongs in iOS 15. Apple changed Safari's layout with iOS 15, and it will...
Read more >How to move Safari's search bar back to the top in iOS 15
Here's how to move Safari's search and address bar back to the top of your iPhone's screen, after the iOS 15 update moved...
Read more >[$1000] Light background colour is shown when navigating ...
[$1000] Light background colour is shown when navigating between right docked modal pages #13086 - Expensify. Search more.
Read more >cannot move search bar from right hand side of screen back to
Right click on the Search bar. If it is locked, uncheck it and then try to move the search bar. Hope the information...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I think we want to have the arrow functionality work for Search like it currently does.
Yep, sounds good @lucas-neuhaus-dev. I think we’d really be looking to remove all traces of anything referencing a ChatSwitcher as part of this step.