New message indicator disappears, report action menu persists after hover
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
- New chat indicator line: should always be displayed on a new message, even after hovering over
- Report action menu: the hover state should end and the menu should become hidden after moving mouse to another message
Actual Result:
- New chat indicator line: when hovered over, the new chat indicator line disappears (0:02 in video)
- Report action menu: hover state persists and menu remains displayed after moving mouse to another message - 2 menus can be seen (0:09 in video)
Action Performed:
- Log into expensify.cash on the web or desktop app
- Go to a chat with unread messages
- Hover over the new message line indicator, line disappears (actual result 1)
- In the same (new) chat, over over the
Copy
function in the report action menu - Slowly move the cursor to another message, message state in first message persists (actual result 2)
Workaround:
No need, visual issue.
Platform:
Where is this issue occurring?
Web ✔️ iOS Android Desktop App ✔️ Mobile Web
Version Number: 1.0.28-0
Notes/Photos/Videos:
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/161784
From @roryabraham https://expensify.slack.com/archives/C01GTK53T8Q/p1619042344491700
ISSUE: When hovering a chat with the NEW chat indicator, the chat indicator disappears. Furthermore, the hover state of the report action is sometimes persisted when it should not be (note in the second screenshot that there are two hovered report actions. To reproduce the first part, hover over a new chat, and the new chat indicator will disappear. To reproduce the second part, slowly move the cursor from a new chat to the one above. Fiddle with it and it’s pretty easy to reproduce the incorrect hover state.
Issue Analytics
- State:
- Created 2 years ago
- Comments:10 (6 by maintainers)
Top GitHub Comments
Oop, gotcha @parasharrajat! Thanks, please also post a proposal on the Upwork job so I can hire you! Will flag this for payment after the 7 day hold period per our normal process, assuming no regressions.
Okay, thanks @parasharrajat, feel free to submit a PR