[Pay 5/19] Wrap text when it includes markup
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
When sending a message with a hyperlink, any text within that message/paragraph which won’t fit in the current window should wrap onto the next line within the current window. When resizing the window, this should change where the wrap in the text occurs.
Actual Result:
When sending a message with a hyperlink, the text sent remains on one line and cannot be scrolled to the right to read the remaining text.
Action Performed:
- Open staging.expensify.cash
- Sign in if not already
- Enter a chat with anybody
- Send the message:
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum
- This should wrap the text perfectly.
- Send the message:
www.expensify.com Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum
- This will send the message on just one line.
Workaround:
Try to copy the line and paste it into the compose box (or some other text editor) in order to read what was written.
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Haven’t been able to repro on iOS or Android. Not sure what the PR that introduced it was. Perhaps https://github.com/Expensify/Expensify.cash/pull/2320? @yuwenmemon?
Version Number: 1.0.41-9 (1.0.41-9) on staging.expensify.cash Logs: N/A Notes/Photos/Videos:
Expensify/Expensify Issue URL: Do I need this? I thought I could just create this here? cc @Expensify/contributor-management
Issue Analytics
- State:
- Created 2 years ago
- Comments:14 (10 by maintainers)
Top GitHub Comments
@roryabraham It’s ready. Will be listed in few minutes.
Verified this fix in
1.0.43-3
: