Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
[Regression test steps needed] [$1000] Request/Send money available in default-rooms/chatrooms with 2 members, error if used.
See original GitHub issueIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- FAB -> Create workspace.
- Settings -> Workspaces -> Manage members. Ensure it has exactly two members.
- Open #admin or #announce room, click + and notice that Request/Send money options are available.
- Select
Request money-> Enter any amount -> Select Next -> Select Request
Expected Result:
Request/Send money options should not be available in default rooms.
Actual Result:
Request/Send money options are available, using them results in error.
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: @Ollyws
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669560477526229
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0188ec5bdeb4f1e5b7
- Upwork Job ID: 1597173028123549696
Issue Analytics
- State:
- Created 10 months ago
- Comments:38 (25 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
In a default room or user created policy room it does not make sense to show the send/request money options as those can only happen in a DM or policy expense chat (though the policy expense chats are still behind a beta IIRC so not sure it’s really relevant to this conversation).
It seems like we still want to allow splitting a bill (though less sure how valuable that is cc @trjExpensify) - kind of a tangent though.
I think for this issue the main thing is that we shouldn’t be seeing the request/send options in default rooms with 2 members and the solution is to wrap the place where we push those options in with a check to
ReportUtils.isChatRoom().@Ollyws first solution is in the right spot - but not sure if they realized how it would affect the bill split feature (which again, isn’t entirely clear that we would necessarily want that behavior).
unassigning me as @thesahindia was assigned for PR review!