question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Updates to validation check messaging when inviting email/phone numbers

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding!


Current

Right now, when start a chat with a new user who you’ve never chatted with before, and you enter only letters this is what you see. image This shows until you enter a valid email format, at which point you see this. image

Alternatively, if you enter just numbers, this is what you see from the start. image

Unless you enter a number starting with 0, in which case you see this. image

New

Instead of this, here’s how we’d like it to work:

  1. Remove the feedback message “Don’t see who you’re looking for? Type their email or phone number to invite them to chat.”
  2. When typing, if the input does not match a valid email or phone number format then show the what they’ve typed below, but greyed out and unselectable.
  3. Once the input matches a valid email or phone number format then show the option as selectable (as we do today)
  4. If the input is only numbers and begins with 0, then display message Please enter a phone number including the country code e.g +447814266907

Internal issue: https://github.com/Expensify/Expensify/issues/154200 Upwork job: https://www.upwork.com/jobs/~01c64a96ae738dcc05

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
johndev0711commented, Mar 25, 2021

Hello. This is John. I’ve solved the issues simply and perfectly. The solutions are as following: It needs to modifying for mainly only one file. ( getHeaderMessage in OptionsListUtils.js, ) In a word, we have to add the props-searchValue in the getHeaderMessage function and modify the function comments. image By modifying the only four line code, I’ve fixed all issues.

  1. 1.Remove the feedback message “Don’t see who you’re looking for? Type their email or phone number to invite them to chat.”
  2. When typing, if the input does not match a valid email or phone number format then show the what they’ve typed below, but greyed out and unselectable.
  3. Once the input matches a valid email or phone number format then show the option as selectable (as we do today)
  4. If the input is only numbers and begins with 0, then display message Please enter a phone number including the country code e.g +447814266907

Thanks.

0reactions
kaushiktdcommented, Mar 26, 2021

Hi,

This is Kaushik here. I would like to put a technical and pretty self explanatory solution for this

  1. Remove the feedback message “Don’t see who you’re looking for? Type their email or phone number to invite them to chat.” 2. When typing, if the input does not match a valid email or phone number format then show what they’ve typed below, but greyed out and unselectable. 3. Once the input matches a valid email or phone number format then show the option as selectable (as we do today) 4. If the input only numbers and begins with 0, then display message Please enter a phone number including the country code e.g +447814266907
Read more comments on GitHub >

github_iconTop Results From Across the Web

6 Reasons to Validate Mobile Phone Numbers for Your ...
Phone number validation checks the accuracy of numbers in your database. ... Send SMS order updates for improved customer experience.
Read more >
Configuring SMS and email verification messages ...
The SMS and email verification message templates only appear if you have chosen to require phone number and email verification in the Verifications...
Read more >
Validate Mobile Phone Numbers | Customer.io Docs
Whenever someone signs up and has a phone attribute, you will automatically obtain the line type . You can then segment based on...
Read more >
Validating User Email Address
The user email address validation will make you sure that the user that registered has used the real email. This short guide helps...
Read more >
Email Address Deliverability and Validation
Click Database in the top navigation bar and select Email Deliverability. Enter an email address. Click Validate. Can an email address be ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found