question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[User Settings] Add new Preferences view

See original GitHub issue

If you haven’t already, check out our contributing guidelines for onboarding!


Having added four new menu items to the Settings page, we now need to begin linking those menu items to actual pages. This issue pertains to the Preferences page.

The Preferences view will be displayed when the “Preferences” menu item is clicked. It will display a header with a left-facing arrow on the left-hand side, a title, and an X button to close the view on the right-hand side. The view will a toggle with the text Relevant feature updates and Expensify news.

Deliverables

  • Clicking on the Preferences menu item on the Settings page will route the user to settings/preferences the existing preferences in ROUTES.js and display the new view
  • The enabled/disabled status of the toggle will depend on the value of the user.expensifyNewsStatus key
    • If the key doesn’t exist or is empty, the field should default to true
  • Toggling the switch should call User.setExpensifyNewsStatus
  • Pressing X will close the right-hand modal and route the user back to the last viewed report
  • Pressing < should display the main settings view.
Mobile Web/Desktop

Job posting: https://www.upwork.com/jobs/~01c4b1365d3b23397b

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

3reactions
michelle-thompsoncommented, Mar 9, 2021

Perhaps we should just update the toggle copy?

cc @joaniew @trjExpensify @JmillsExpensify @NikkiWines

1reaction
Maftalioncommented, Mar 9, 2021

Proposed Solution

  • RN’s Switch component, behaves differently on different platform (screenshot below for android/web). So we can bring in a javascript implementation like https://github.com/aminebenkeroum/toggle-switch-react-native to have design parity across all platforms. Screen Shot 2021-03-09 at 9 41 59 AM

  • The default will go based on expensifyNewsStatus or default to true, then toggles will update that value by calling setExpensifyNewsStatus.

Questions Pressing X or < should display the main settings view.

  • Current functionality would go back to main when < is pressed and close completely when x is pressed. Do we want to keep that or should both go back to main settings? (if so it might make more sense to just hide the x)
Read more comments on GitHub >

github_iconTop Results From Across the Web

Change User settings on Mac - Apple Support
Learn how to set up a new user. To change these settings, choose Apple menu > System Settings, then click Users & Groups...
Read more >
User preference settings - Product Documentation | ServiceNow
Preference Category Updated by .db.order List Sort Admin or User .db.order.direction List Sort Admin or User bsm_map.default_ci BSM User Only
Read more >
Manage user settings and preferences as the administrator
The User Settings list shows the current settings for each user. To view or edit individual users, choose the View or Edit action....
Read more >
User Preferences, Editor Settings and Editor Toolbars
Click the Editor Settings icon on the top toolbar. Editor Settings · In the Editor Settings dialog, click the Attributes List tab. ·...
Read more >
User and Workspace Settings - Visual Studio Code
The gear icon (More Actions... Shift+F9) opens a context menu with options to reset the setting to its default value as well as...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found