Error when used in overnightjs project

Caused by incorrect placing of parentheses during the isArray check.

Existing https://github.com/express-promise-router/express-promise-router/blob/6bf785ae1f04e12cb209745642d377cb99a80020/lib/express-promise-router.js#L80

Modified

(Array.isArray(args[0]) && ('string' === typeof args[0][0] || args[0][0] instanceof RegExp))

Possibly relates to https://github.com/express-promise-router/express-promise-router/issues/46

[andrewmackrodt]

That is a different issue, if you believe you’re using the library correctly I’d recommend creating a new issue.

[andrewmackrodt]

In my instance this was caused by incorrect usage of overnightjs (potentially a bug in overnightjs itself) and possibly covered in the FAQ. I still believe this issue to be valid but cannot think of a failing test case when the library is used correctly.

import {Controller, Delete, Get, Options, Patch, Post, Put} from '@overnightjs/core'
import {Request, Response} from 'express'
import {constants as status} from 'http2'

@Controller('*')
export class NotFoundController {
    // these routes are ok
    @Options('') public optionsNotFound(req: Request, res: Response) { this.notFound(req, res) }
    @Get('') public getNotFound(req: Request, res: Response) { this.notFound(req, res) }
    @Patch('') public patchNotFound(req: Request, res: Response) { this.notFound(req, res) }
    @Put('') public putNotFound(req: Request, res: Response) { this.notFound(req, res) }
    @Post('') public postNotFound(req: Request, res: Response) { this.notFound(req, res) }

    // this one will cause the error
    @Delete() public deleteNotFound(req: Request, res: Response) { this.notFound(req, res) }

    private notFound(req: Request, res: Response) {
        res.status(status.HTTP_STATUS_NOT_FOUND).json({error: 'Not Found'})
    }
}

When a “correct” route is defined, args[0] is a callback so the check for args[0][0] does not fail (args[callback][0] == undefined). In the “incorrect” route example, args is empty so args[undefined][0] == error.