Bug: release 6.9.1 breaks TypeScript compiler (TSC) build

Describe the bug

When I run tsc on my codebase with 6.9.1 I get a whole load of errors

To Reproduce

Run tsc

Expected behavior

No errors

Current behavior

Lots of errors, stacktrace as follows:

node_modules/express-validator/src/chain/context-runner-impl.ts(32,74): error TS7006: Parameter 'instance' implicitly has an 'any' type.
node_modules/express-validator/src/chain/sanitizers-impl.ts(1,28): error TS7016: Could not find a declaration file for module 'validator'. '/node_modules/validator/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/validator` if it exists or add a new declaration (.d.ts) file containing `declare module 'validator';`
node_modules/express-validator/src/chain/validators-impl.ts(1,28): error TS7016: Could not find a declaration file for module 'validator'. '/node_modules/validator/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/validator` if it exists or add a new declaration (.d.ts) file containing `declare module 'validator';`
node_modules/express-validator/src/context.ts(40,12): error TS2349: This expression is not callable.
  Type '{ default: LoDashStatic; VERSION: string; templateSettings: TemplateSettings; chunk<T>(array: List<T>, size?: number): T[][]; compact<T>(array: List<false | "" | 0 | T>): T[]; ... 302 more ...; uniqueId(prefix?: string): string; }' has no call signatures.
node_modules/express-validator/src/context.ts(42,17): error TS7006: Parameter 'instances' implicitly has an 'any' type.
node_modules/express-validator/src/context.ts(42,28): error TS7006: Parameter 'group' implicitly has an 'any' type.
node_modules/express-validator/src/context.ts(50,46): error TS7006: Parameter 'instance' implicitly has an 'any' type.
node_modules/express-validator/src/context.ts(56,15): error TS7006: Parameter 'instance' implicitly has an 'any' type.
node_modules/express-validator/src/matched-data.ts(26,10): error TS2349: This expression is not callable.
  Type '{ default: LoDashStatic; VERSION: string; templateSettings: TemplateSettings; chunk<T>(array: List<T>, size?: number): T[][]; compact<T>(array: List<false | "" | 0 | T>): T[]; ... 302 more ...; uniqueId(prefix?: string): string; }' has no call signatures.
node_modules/express-validator/src/matched-data.ts(29,10): error TS7006: Parameter 'field' implicitly has an 'any' type.
node_modules/express-validator/src/matched-data.ts(31,14): error TS7006: Parameter 'state' implicitly has an 'any' type.
node_modules/express-validator/src/matched-data.ts(31,21): error TS7006: Parameter 'instance' implicitly has an 'any' type.
node_modules/express-validator/src/matched-data.ts(38,27): error TS7006: Parameter 'instance' implicitly has an 'any' type.
node_modules/express-validator/src/select-fields.ts(11,3): error TS2349: This expression is not callable.
  Type '{ default: LoDashStatic; VERSION: string; templateSettings: TemplateSettings; chunk<T>(array: List<T>, size?: number): T[][]; compact<T>(array: List<false | "" | 0 | T>): T[]; ... 302 more ...; uniqueId(prefix?: string): string; }' has no call signatures.
node_modules/express-validator/src/select-fields.ts(12,14): error TS7006: Parameter 'field' implicitly has an 'any' type.

Express-validator version:

tsc works on 6.9.0 and earlier versions tsc breaks on 6.9.1

[gustavohenke]

Republished as v6.9.2. Let me know if it doesn’t fix the issue.

[erezsdev]

Same here.

node_modules/express-validator/src/matched-data.ts:28:13 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(predicate: ListIteratorTypeGuard<boolean, boolean>): Collection<boolean>', gave the following error.
    Argument of type '(field: FieldInstanceBag) => boolean' is not assignable to parameter of type 'ListIteratorTypeGuard<boolean, boolean>'.
      Types of parameters 'field' and 'value' are incompatible.
        Type 'boolean' is not assignable to type 'FieldInstanceBag'.
  Overload 2 of 2, '(predicate?: ListIterateeCustom<boolean, boolean>): Collection<boolean>', gave the following error.
    Argument of type '(field: FieldInstanceBag) => boolean' is not assignable to parameter of type 'ListIterateeCustom<boolean, boolean>'.
      Type '(field: FieldInstanceBag) => boolean' is not assignable to type 'ListIterator<boolean, boolean>'.
        Types of parameters 'field' and 'value' are incompatible.
          Type 'boolean' is not assignable to type 'FieldInstanceBag'.

28     .filter(validityFilter)
               ~~~~~~~~~~~~~~

  node_modules/express-validator/src/matched-data.ts:28:13
    28     .filter(validityFilter)
                   ~~~~~~~~~~~~~~
    Did you mean to call this expression?

node_modules/express-validator/src/matched-data.ts:29:25 - error TS2339: Property 'instance' does not exist on type 'boolean'.

29     .map(field => field.instance)
                           ~~~~~~~~

node_modules/express-validator/src/middlewares/schema.ts:67:15 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(predicate: (value: string, index: number, array: string[]) => value is "replace" | "toLowerCase" | "toUpperCase" | "trim" | "isEmpty" | "customSanitizer" | "default" | "blacklist" | "escape" | "unescape" | ... 93 more ... | "matches", thisArg?: any): ("replace" | ... 102 more ... | "matches")[]', gave the following error.
    Argument of type '(method: keyof ParamSchema) => method is "replace" | "toLowerCase" | "toUpperCase" | "trim" | "isEmpty" | "customSanitizer" | "default" | "blacklist" | "escape" | "unescape" | "ltrim" | "normalizeEmail" | ... 91 more ... | "matches"' is not assignable to parameter of type '(value: string, 
index: number, array: string[]) => value is "replace" | "toLowerCase" | "toUpperCase" | "trim" | "isEmpty" | "customSanitizer" | "default" | "blacklist" | "escape" | "unescape" | ... 93 more ... | "matches"'.
      Types of parameters 'method' and 'value' are incompatible.
        Type 'string' is not assignable to type '"replace" | "toLowerCase" | "toUpperCase" | "trim" | "isEmpty" | "optional" | "customSanitizer" | "default" | "blacklist" | "escape" | "unescape" | "ltrim" | "normalizeEmail" | ... 93 more ... | "in"'.
  Overload 2 of 2, '(predicate: (value: string, index: number, array: string[]) => unknown, thisArg?: any): string[]', gave the following error.
    Argument of type '(method: keyof ParamSchema) => method is "replace" | "toLowerCase" | "toUpperCase" | "trim" | "isEmpty" | "customSanitizer" | "default" | "blacklist" | "escape" | "unescape" | "ltrim" | "normalizeEmail" | ... 91 more ... | "matches"' is not assignable to parameter of type '(value: string, 
index: number, array: string[]) => unknown'.
      Types of parameters 'method' and 'value' are incompatible.
        Type 'string' is not assignable to type '"replace" | "toLowerCase" | "toUpperCase" | "trim" | "isEmpty" | "optional" | "customSanitizer" | "default" | "blacklist" | "escape" | "unescape" | "ltrim" | "normalizeEmail" | ... 93 more ... | "in"'.

67       .filter((method: keyof ParamSchema): method is keyof InternalParamSchema => {
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



Found 3 errors.