`custom()` validation not working

Here’s an abstract of the code I’m working with:

import { check } from 'express-validator/check';

router.post(
  '/myendpoint',
  [
    check('myparameter', 'This should be hardcoded to fail')
      .custom((value, { req }) => {
        console.log(value);
        return false;
      })
  ],
  myEndpointHandler
);

I’m using a custom check to validate a query parameter, and after trying everything to get it to work, I distilled it down to something that looks just like the code in the documentation, and it still won’t work. It’s not asynchronous, it’s just a boolean check. I took out my boolean check and hardcoded in false, but it still doesn’t work. I’m running it with v4.3.0. I added the console.log(value) and it’s printing the correct value that gets passed in. Is there something I’m missing, or is custom() not fully working, or is the documentation out of date?

Thanks!

[gustavohenke]

Hey guys, so I checked both of your codes and they both work.

@valeco I added a console.log(req.flash()) to your error handler and it prints all messages, including Wrong! 😉

@KrashLeviathan I replaced that route with the following:

router.post(
  '/foo',
  // authController.isAuthenticated,
  check('daysFromCreationUntilExpiration', 'This should be hardcoded to fail')
      .custom((value, { req }) => {
        console.log(value);
        return false;
      }),
  (req, res, next) => {
    const errors = validationResult(req).mapped();
    res.json({ errors });
  }
);

You were probably missing the call to validationResult.

Will close the issue for now. Feel free to continue the discussion.

[gustavohenke]

Sorry @valeco but I still can’t reproduce. I commented out the other validators and sanitisers and it still works. I must also comment that I had to remove the mongoose connection.

Can you please create a minimal example that reproduces your issue?