How to use custom validator for nested validate

Hi, in this code the value of hasLogin is true or false and always it is a boolean value, but I get Invalid value error for it. what is wrong in my code? Can I use express-validator like this?

return [
     check("hasLogin", "Invalid data").isBoolean(),
     check("isInteraction", "Invalid data").isBoolean(),
     check("hasLogin").custom((hasLogin) => {
        if (hasLogin) {
            check("link").isURL().withMessage("Invalid website url");
            check("loginPage").isURL().withMessage("Invalid login page url");
            check("username", "Username must be string").isAlpha();
            check("password", "Password must be string").isAlpha();
            check("dataPage", "Invalid data page url").isURL();
        } else {
            check("pageUrl", "Invalid website url").isURL();
        }
      })
    ];

[Rouzz]

Okay so you want the custom validation to be valid if all sub-validations are valid and false otherwise ?

If that’s the case, I don’t know if there is a proper way to do it. Basically you need to access the validationResult and make the return depend on it.

The issue is that as far as I can tell, validationResult requires req as a parameter. You could try using a custom function as a middleware :

return [
     check("hasLogin", "Invalid data").isBoolean(),
     check("isInteraction", "Invalid data").isBoolean(),
     function(req, res, next) {
        // Guessing you get hasLogin from body, please align with your way to get hasLogin in the app
        if (req.body.hasLogin) {
            check("link").isURL().withMessage("Invalid website url");
            check("loginPage").isURL().withMessage("Invalid login page url");
            check("username", "Username must be string").isAlpha();
            check("password", "Password must be string").isAlpha();
            check("dataPage", "Invalid data page url").isURL();
        } else {
            check("pageUrl", "Invalid website url").isURL();
        }
        const errors = validationResult(req);
        return errors.isEmpty();
      })
    ];

This would need to be tested. And based on what you want to do, you may want to count the current number of errors before your if/else condition and return true if the count went up after you added the new checks.

Hope this helps.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.